]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
intel_th: pti: Use sysfs_match_string() helper
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 4 May 2018 19:19:25 +0000 (22:19 +0300)
committerAlexander Shishkin <alexander.shishkin@linux.intel.com>
Thu, 21 Feb 2019 13:04:36 +0000 (15:04 +0200)
Use sysfs_match_string() helper instead of open coded variant.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
drivers/hwtracing/intel_th/pti.c

index 56694339cb068591d255666244a7875a1c43be6e..0da6b787f55367ff0a1e07b07e4da673c2656be4 100644 (file)
@@ -272,19 +272,17 @@ static ssize_t lpp_dest_store(struct device *dev, struct device_attribute *attr,
                              const char *buf, size_t size)
 {
        struct pti_device *pti = dev_get_drvdata(dev);
-       ssize_t ret = -EINVAL;
        int i;
 
-       for (i = 0; i < ARRAY_SIZE(lpp_dest_str); i++)
-               if (sysfs_streq(buf, lpp_dest_str[i]))
-                       break;
+       i = sysfs_match_string(lpp_dest_str, buf);
+       if (i < 0)
+               return i;
 
-       if (i < ARRAY_SIZE(lpp_dest_str) && pti->lpp_dest_mask & BIT(i)) {
-               pti->lpp_dest = i;
-               ret = size;
-       }
+       if (!(pti->lpp_dest_mask & BIT(i)))
+               return -EINVAL;
 
-       return ret;
+       pti->lpp_dest = i;
+       return size;
 }
 
 static DEVICE_ATTR_RW(lpp_dest);