]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
[media] v4l: omap3isp: Clean up file handle in open() and release()
authorShailendra Verma <shailendra.v@samsung.com>
Fri, 25 Nov 2016 04:44:32 +0000 (02:44 -0200)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 31 Jan 2017 12:57:58 +0000 (10:57 -0200)
Both functions initialize the file handle with v4l2_fh_init() and thus
need to call clean up with v4l2_fh_exit() as appropriate. Fix it.

Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/omap3isp/ispvideo.c

index 25a8210f0a6d5c9de9eb958f8d8a613b80e53a38..218e6d7ae93ae003c7600ea9b1c268cf2305b7ed 100644 (file)
@@ -1350,6 +1350,7 @@ static int isp_video_open(struct file *file)
 done:
        if (ret < 0) {
                v4l2_fh_del(&handle->vfh);
+               v4l2_fh_exit(&handle->vfh);
                kfree(handle);
        }
 
@@ -1373,6 +1374,7 @@ static int isp_video_release(struct file *file)
 
        /* Release the file handle. */
        v4l2_fh_del(vfh);
+       v4l2_fh_exit(vfh);
        kfree(handle);
        file->private_data = NULL;