]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
platform/x86: dell-smbios: make a function and a pointer static
authorColin Ian King <colin.king@canonical.com>
Thu, 21 Jun 2018 18:15:24 +0000 (19:15 +0100)
committerDarren Hart (VMware) <dvhart@infradead.org>
Tue, 26 Jun 2018 22:12:20 +0000 (15:12 -0700)
The function dell_smbios_smm_call and pointer platform_device are
local to the source and do not need to be in global scope, so make
them static.

Cleans up sparse warnings:
warning: symbol 'platform_device' was not declared. Should it be static?
warning: symbol 'dell_smbios_smm_call' was not declared. Should it be
static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
drivers/platform/x86/dell-smbios-smm.c

index e9e9da556318703275ac6cb9eef59ae7426d4776..97a90bebc36079f5ff716b8d739bd27928aa442a 100644 (file)
@@ -24,7 +24,7 @@
 static int da_command_address;
 static int da_command_code;
 static struct calling_interface_buffer *buffer;
-struct platform_device *platform_device;
+static struct platform_device *platform_device;
 static DEFINE_MUTEX(smm_mutex);
 
 static const struct dmi_system_id dell_device_table[] __initconst = {
@@ -82,7 +82,7 @@ static void find_cmd_address(const struct dmi_header *dm, void *dummy)
        }
 }
 
-int dell_smbios_smm_call(struct calling_interface_buffer *input)
+static int dell_smbios_smm_call(struct calling_interface_buffer *input)
 {
        struct smi_cmd command;
        size_t size;