]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
Bluetooth: make hw_err static, reduces object code size
authorColin Ian King <colin.king@canonical.com>
Thu, 24 Jan 2019 17:22:54 +0000 (17:22 +0000)
committerMarcel Holtmann <marcel@holtmann.org>
Fri, 25 Jan 2019 07:53:58 +0000 (08:53 +0100)
Don't populate the const array hw_err on the stack but instead make
it static. Makes the object code smaller by 45 bytes:

Before:
   text    data     bss     dec     hex filename
 100880   21090    1088  123058   1e0b2 linux/net/bluetooth/hci_core.o

After:
   text    data     bss     dec     hex filename
 100739   21186    1088  123013   1e085 linux/net/bluetooth/hci_core.o

(gcc version 8.2.0 x86_64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
net/bluetooth/hci_core.c

index 75793265ba9ec3184c18f0ed100a86722cc2a8cb..26e3d36aee2989ed038a3a03f45f39444f7ba699 100644 (file)
@@ -3404,7 +3404,7 @@ EXPORT_SYMBOL(hci_resume_dev);
 /* Reset HCI device */
 int hci_reset_dev(struct hci_dev *hdev)
 {
-       const u8 hw_err[] = { HCI_EV_HARDWARE_ERROR, 0x01, 0x00 };
+       static const u8 hw_err[] = { HCI_EV_HARDWARE_ERROR, 0x01, 0x00 };
        struct sk_buff *skb;
 
        skb = bt_skb_alloc(3, GFP_ATOMIC);