]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: lirc_zilog: Clean up tests if NULL returned on failure
authorsimran singhal <singhalsimran0@gmail.com>
Fri, 10 Mar 2017 05:13:12 +0000 (10:43 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 12 Mar 2017 13:57:00 +0000 (14:57 +0100)
Some functions like kmalloc/kzalloc return NULL on failure.
When NULL represents failure, !x is commonly used.

This was done using Coccinelle:
@@
expression *e;
identifier l1;
@@

e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...);
...
- e == NULL
+ !e

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/media/lirc/lirc_zilog.c

index e4a533b6beb3766d9be52497154c07179955c252..f426460ccd54016d7992861d89fcaeef5e2af9d2 100644 (file)
@@ -1475,7 +1475,7 @@ static int ir_probe(struct i2c_client *client, const struct i2c_device_id *id)
        ir = get_ir_device_by_adapter(adap);
        if (ir == NULL) {
                ir = kzalloc(sizeof(struct IR), GFP_KERNEL);
-               if (ir == NULL) {
+               if (!ir) {
                        ret = -ENOMEM;
                        goto out_no_ir;
                }
@@ -1515,7 +1515,7 @@ static int ir_probe(struct i2c_client *client, const struct i2c_device_id *id)
 
                /* Set up a struct IR_tx instance */
                tx = kzalloc(sizeof(struct IR_tx), GFP_KERNEL);
-               if (tx == NULL) {
+               if (!tx) {
                        ret = -ENOMEM;
                        goto out_put_xx;
                }
@@ -1559,7 +1559,7 @@ static int ir_probe(struct i2c_client *client, const struct i2c_device_id *id)
 
                /* Set up a struct IR_rx instance */
                rx = kzalloc(sizeof(struct IR_rx), GFP_KERNEL);
-               if (rx == NULL) {
+               if (!rx) {
                        ret = -ENOMEM;
                        goto out_put_xx;
                }