media: vimc: Fix error return code in vimc_register_devices()

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: f13d5f361959 ("media: vimc: Collapse component structure into a single monolithic driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Helen Koike <helen.koike@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

diff --git a/drivers/media/platform/vimc/vimc-core.c b/drivers/media/platform/vimc/vimc-core.c
index 6e3e5c91ae390751006fa884d5eaee8d49ad2fbc..2d20a7c103986d437f2f968743b89c44151f2195 100644 (file)
--- a/drivers/media/platform/vimc/vimc-core.c
+++ b/drivers/media/platform/vimc/vimc-core.c
@@ -202,8 +202,10 @@ static int vimc_register_devices(struct vimc_device *vimc)
        vimc->ent_devs = kmalloc_array(vimc->pipe_cfg->num_ents,
                                       sizeof(*vimc->ent_devs),
                                       GFP_KERNEL);
-       if (!vimc->ent_devs)
+       if (!vimc->ent_devs) {
+               ret = -ENOMEM;
                goto err_v4l2_unregister;
+       }
 
        /* Invoke entity config hooks to initialize and register subdevs */
        ret = vimc_add_subdevs(vimc);