]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
dmaengine: bcm-scm-raid: remove redundant null check on req
authorColin Ian King <colin.king@canonical.com>
Wed, 17 May 2017 21:58:50 +0000 (22:58 +0100)
committerVinod Koul <vinod.koul@intel.com>
Fri, 19 May 2017 03:26:16 +0000 (08:56 +0530)
Req is never null on at the point of the null check, so
remove this redundant check and just return &req->tx.

Detected by CoverityScan, CID#1436147 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/bcm-sba-raid.c

index d6b927b960ab3d04a39c8fa139bdbd3672fb6e0d..e41bbc7cb0941bb181125870c63aa89ef1598d18 100644 (file)
@@ -582,7 +582,7 @@ sba_prep_dma_interrupt(struct dma_chan *dchan, unsigned long flags)
        req->tx.flags = flags;
        req->tx.cookie = -EBUSY;
 
-       return (req) ? &req->tx : NULL;
+       return &req->tx;
 }
 
 static void sba_fillup_memcpy_msg(struct sba_request *req,