]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
phy: mapphone-mdm6600: add gpiolib dependency
authorArnd Bergmann <arnd@arndb.de>
Mon, 4 Mar 2019 20:23:58 +0000 (21:23 +0100)
committerKishon Vijay Abraham I <kishon@ti.com>
Wed, 17 Apr 2019 06:36:02 +0000 (12:06 +0530)
gcc points out that when CONFIG_GPIOLIB is disabled,
gpiod_get_array_value_cansleep() returns 0 but fails to set its output:

drivers/phy/motorola/phy-mapphone-mdm6600.c: In function 'phy_mdm6600_status':
drivers/phy/motorola/phy-mapphone-mdm6600.c:220:24: error: 'values[0]' is used uninitialized in this function [-Werror=uninitialized]

This could be fixed more generally in gpiolib by returning a failure
code, but for this specific case, the easier workaround is to add a
gpiolib dependency.

Fixes: 5d1ebbda0318 ("phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/motorola/Kconfig

index 82651524ffb9ce33424dd5a3eb9851cc14eef11f..718f8729701df1d7c0c2763965e611346d5194fe 100644 (file)
@@ -13,7 +13,7 @@ config PHY_CPCAP_USB
 
 config PHY_MAPPHONE_MDM6600
        tristate "Motorola Mapphone MDM6600 modem USB PHY driver"
-       depends on OF && USB_SUPPORT
+       depends on OF && USB_SUPPORT && GPIOLIB
        select GENERIC_PHY
        help
          Enable this for MDM6600 USB modem to work on Motorola phones