]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
bcache: Reduce the number of sparse complaints about lock imbalances
authorBart Van Assche <bart.vanassche@wdc.com>
Mon, 19 Mar 2018 00:36:32 +0000 (17:36 -0700)
committerJens Axboe <axboe@kernel.dk>
Mon, 19 Mar 2018 02:15:20 +0000 (20:15 -0600)
Add more annotations for sparse to inform it about which functions do
not have the same number of spin_lock() and spin_unlock() calls.

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Reviewed-by: Michael Lyle <mlyle@lyle.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/md/bcache/journal.c

index acd0e5c074dd0e415e513f12d3f98e378289e4db..18f1b523962042d07e3c27fb6bf2e917a44279b9 100644 (file)
@@ -594,6 +594,7 @@ static void journal_write_done(struct closure *cl)
 }
 
 static void journal_write_unlock(struct closure *cl)
+       __releases(&c->journal.lock)
 {
        struct cache_set *c = container_of(cl, struct cache_set, journal.io);
 
@@ -705,6 +706,7 @@ static void journal_try_write(struct cache_set *c)
 
 static struct journal_write *journal_wait_for_write(struct cache_set *c,
                                                    unsigned nkeys)
+       __acquires(&c->journal.lock)
 {
        size_t sectors;
        struct closure cl;