]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
mtd: rawnand: mxic: Remove dev_err() on platform_get_irq() failure
authorYueHaibing <yuehaibing@huawei.com>
Thu, 24 Oct 2019 02:29:34 +0000 (10:29 +0800)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Tue, 29 Oct 2019 13:40:42 +0000 (14:40 +0100)
platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
drivers/mtd/nand/raw/mxic_nand.c

index 9d49e6c845e1687fe7cf01254d0e077b9edce8b6..ed7a4e021bf58bc2a2c73d557b0f44c355360792 100644 (file)
@@ -524,10 +524,8 @@ static int mxic_nfc_probe(struct platform_device *pdev)
        nand_chip->controller = &nfc->controller;
 
        irq = platform_get_irq(pdev, 0);
-       if (irq < 0) {
-               dev_err(&pdev->dev, "failed to retrieve irq\n");
+       if (irq < 0)
                return irq;
-       }
 
        mxic_nfc_hw_init(nfc);