]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/amd/display: Fix unbalanced locking in surface apply
authorRoman Li <Roman.Li@amd.com>
Tue, 7 Nov 2017 15:58:40 +0000 (10:58 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 6 Dec 2017 17:47:39 +0000 (12:47 -0500)
also simplifying syntax and removing unused variable in
dce110_apply_ctx_for_surface()

Signed-off-by: Roman Li <Roman.Li@amd.com>
Reviewed-by: Tony Cheng <Tony.Cheng@amd.com>
Acked-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c

index 750bbe9edf5c1b347c893dbcfdcdc163fa7ef8cb..09051dfe1844b094f6d42c796c944102d7ca9aed 100644 (file)
@@ -2849,22 +2849,19 @@ static void dce110_apply_ctx_for_surface(
                int num_planes,
                struct dc_state *context)
 {
-       int i, be_idx;
+       int i;
 
        if (num_planes == 0)
                return;
 
-       be_idx = -1;
        for (i = 0; i < dc->res_pool->pipe_count; i++) {
                struct pipe_ctx *pipe_ctx = &context->res_ctx.pipe_ctx[i];
                struct pipe_ctx *old_pipe_ctx = &dc->current_state->res_ctx.pipe_ctx[i];
 
-               if (stream == context->res_ctx.pipe_ctx[i].stream) {
-                       be_idx = context->res_ctx.pipe_ctx[i].stream_res.tg->inst;
+               if (stream == pipe_ctx->stream) {
                        if (!pipe_ctx->top_pipe &&
                                (pipe_ctx->plane_state || old_pipe_ctx->plane_state))
                                dc->hwss.pipe_control_lock(dc, pipe_ctx, true);
-                       break;
                }
        }