]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ieee802154: mcr20a: simplify a bit 'mcr20a_handle_rx_read_buf_complete()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 20 Sep 2019 19:45:33 +0000 (21:45 +0200)
committerStefan Schmidt <stefan@datenfreihafen.org>
Wed, 25 Sep 2019 06:16:51 +0000 (08:16 +0200)
Use a 'skb_put_data()' variant instead of rewritting it.
The __skb_put_data variant is safe here. It is obvious that the skb can
not overflow. It has just been allocated a few lines above with the same
'len'.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Xue Liu <liuxuenetmail@gmail.com>
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
drivers/net/ieee802154/mcr20a.c

index 17f2300e63eed773832d7bb73985b86d562b9508..8dc04e2590b18b1b41239c4ebf8ac1382942a8d5 100644 (file)
@@ -800,7 +800,7 @@ mcr20a_handle_rx_read_buf_complete(void *context)
        if (!skb)
                return;
 
-       memcpy(skb_put(skb, len), lp->rx_buf, len);
+       __skb_put_data(skb, lp->rx_buf, len);
        ieee802154_rx_irqsafe(lp->hw, skb, lp->rx_lqi[0]);
 
        print_hex_dump_debug("mcr20a rx: ", DUMP_PREFIX_OFFSET, 16, 1,