]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
extcon: axp288: Use for_each_set_bit() in axp288_extcon_log_rsi()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 26 Jul 2019 12:18:20 +0000 (15:18 +0300)
committerChanwoo Choi <cw00.choi@samsung.com>
Mon, 29 Jul 2019 01:24:14 +0000 (10:24 +0900)
This simplifies and standardizes axp288_extcon_log_rsi()
by using for_each_set_bit() library function.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/extcon/extcon-axp288.c

index 694a8d4a57ffbfa22a5d1efaeb1101163a1d9cc6..415afaf479e7c732aaadc5bd2d398f3a5678e1ec 100644 (file)
@@ -121,7 +121,6 @@ static const char * const axp288_pwr_up_down_info[] = {
        "Last shutdown caused by PMIC UVLO threshold",
        "Last shutdown caused by SOC initiated cold off",
        "Last shutdown caused by user pressing the power button",
-       NULL,
 };
 
 /*
@@ -130,8 +129,8 @@ static const char * const axp288_pwr_up_down_info[] = {
  */
 static void axp288_extcon_log_rsi(struct axp288_extcon_info *info)
 {
-       const char * const *rsi;
        unsigned int val, i, clear_mask = 0;
+       unsigned long bits;
        int ret;
 
        ret = regmap_read(info->regmap, AXP288_PS_BOOT_REASON_REG, &val);
@@ -140,12 +139,10 @@ static void axp288_extcon_log_rsi(struct axp288_extcon_info *info)
                return;
        }
 
-       for (i = 0, rsi = axp288_pwr_up_down_info; *rsi; rsi++, i++) {
-               if (val & BIT(i)) {
-                       dev_dbg(info->dev, "%s\n", *rsi);
-                       clear_mask |= BIT(i);
-               }
-       }
+       bits = val & GENMASK(ARRAY_SIZE(axp288_pwr_up_down_info) - 1, 0);
+       for_each_set_bit(i, &bits, ARRAY_SIZE(axp288_pwr_up_down_info))
+               dev_dbg(info->dev, "%s\n", axp288_pwr_up_down_info[i]);
+       clear_mask = bits;
 
        /* Clear the register value for next reboot (write 1 to clear bit) */
        regmap_write(info->regmap, AXP288_PS_BOOT_REASON_REG, clear_mask);