]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: emaclite: Use __func__ instead of hardcoded name
authorRadhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Thu, 28 Jun 2018 13:11:46 +0000 (18:41 +0530)
committerDavid S. Miller <davem@davemloft.net>
Sat, 30 Jun 2018 11:15:44 +0000 (20:15 +0900)
Switch hardcoded function name with a reference to __func__ making
the code more maintainable. Address below checkpatch warning:

WARNING: Prefer using '"%s...", __func__' to using 'xemaclite_mdio_read',
this function's name, in a string
+               "xemaclite_mdio_read(phy_id=%i, reg=%x) == %x\n",

WARNING: Prefer using '"%s...", __func__' to using 'xemaclite_mdio_write',
this function's name, in a string
+               "xemaclite_mdio_write(phy_id=%i, reg=%x, val=%x)\n",

Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/xilinx/xilinx_emaclite.c

index 2a0c06e0f730c35e5e7d40d9d9893bf36cf9c6fa..0544134959bf02ca814e1bd9fa5a6bf41e641d09 100644 (file)
@@ -757,7 +757,7 @@ static int xemaclite_mdio_read(struct mii_bus *bus, int phy_id, int reg)
        rc = xemaclite_readl(lp->base_addr + XEL_MDIORD_OFFSET);
 
        dev_dbg(&lp->ndev->dev,
-               "xemaclite_mdio_read(phy_id=%i, reg=%x) == %x\n",
+               "%s(phy_id=%i, reg=%x) == %x\n", __func__,
                phy_id, reg, rc);
 
        return rc;
@@ -780,7 +780,7 @@ static int xemaclite_mdio_write(struct mii_bus *bus, int phy_id, int reg,
        u32 ctrl_reg;
 
        dev_dbg(&lp->ndev->dev,
-               "xemaclite_mdio_write(phy_id=%i, reg=%x, val=%x)\n",
+               "%s(phy_id=%i, reg=%x, val=%x)\n", __func__,
                phy_id, reg, val);
 
        if (xemaclite_mdio_wait(lp))