]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
remoteproc/davinci: add the missing retval check for clk_enable()
authorBartosz Golaszewski <bgolaszewski@baylibre.com>
Wed, 2 May 2018 09:56:57 +0000 (11:56 +0200)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Wed, 9 May 2018 21:30:34 +0000 (14:30 -0700)
The davinci platform is being switched to using the common clock
framework, where clk_enable() can fail. Add the return value check.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Acked-by: Suman Anna <s-anna@ti.com>
Reviewed-by: David Lechner <david@lechnology.com>
Reviewed-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/remoteproc/da8xx_remoteproc.c

index bf3b9034c319eed88f86a1ef3fd61792f389466e..2b24291337b7ef21ad83c938a529fccd9363b13d 100644 (file)
@@ -138,6 +138,7 @@ static int da8xx_rproc_start(struct rproc *rproc)
        struct device *dev = rproc->dev.parent;
        struct da8xx_rproc *drproc = (struct da8xx_rproc *)rproc->priv;
        struct clk *dsp_clk = drproc->dsp_clk;
+       int ret;
 
        /* hw requires the start (boot) address be on 1KB boundary */
        if (rproc->bootaddr & 0x3ff) {
@@ -148,7 +149,12 @@ static int da8xx_rproc_start(struct rproc *rproc)
 
        writel(rproc->bootaddr, drproc->bootreg);
 
-       clk_enable(dsp_clk);
+       ret = clk_enable(dsp_clk);
+       if (ret) {
+               dev_err(dev, "clk_enable() failed: %d\n", ret);
+               return ret;
+       }
+
        davinci_clk_reset_deassert(dsp_clk);
 
        return 0;