]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
NFS: don't expect errors from mempool_alloc().
authorNeilBrown <neilb@suse.com>
Fri, 18 Aug 2017 07:12:51 +0000 (17:12 +1000)
committerTrond Myklebust <trond.myklebust@primarydata.com>
Wed, 6 Sep 2017 16:31:15 +0000 (12:31 -0400)
Commit fbe77c30e9ab ("NFS: move rw_mode to nfs_pageio_header")
reintroduced some pointless code that commit 518662e0fcb9 ("NFS: fix
usage of mempools.") had recently removed.

Remove it again.

Cc: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
fs/nfs/write.c

index 1a877d17e6cbe5b6946be2a591656cec4ee2333b..ae26775b5448a7e0885a97072f9b2eb1064c4840 100644 (file)
@@ -102,10 +102,8 @@ static struct nfs_pgio_header *nfs_writehdr_alloc(void)
 {
        struct nfs_pgio_header *p = mempool_alloc(nfs_wdata_mempool, GFP_NOIO);
 
-       if (p) {
-               memset(p, 0, sizeof(*p));
-               p->rw_mode = FMODE_WRITE;
-       }
+       memset(p, 0, sizeof(*p));
+       p->rw_mode = FMODE_WRITE;
        return p;
 }