sk_nonamelookup() should ensure the sockaddr it returns has `error'

set to NULL. Otherwise it'll be random uninitialised goop. Not good.

[originally from svn r2416]

diff --git a/unix/uxnet.c b/unix/uxnet.c
index 3440d19e1505994449e5399f741e89480cabddbb..82b413dcff03da10f62ec540f1826861902d3001 100644 (file)
--- a/unix/uxnet.c
+++ b/unix/uxnet.c
@@ -203,6 +203,7 @@ SockAddr sk_namelookup(char *host, char **canonicalname)
 SockAddr sk_nonamelookup(char *host)
 {
     SockAddr ret = smalloc(sizeof(struct SockAddr_tag));
+    ret->error = NULL;
     ret->family = AF_UNSPEC;
     strncpy(ret->hostname, host, lenof(ret->hostname));
     ret->hostname[lenof(ret->hostname)-1] = '\0';

diff --git a/winnet.c b/winnet.c
index e94075b5df3e8d2d6c5513920dea73b3018681b1..0b93fcd2973723d82c1093b00a1c23ee19f42957 100644 (file)
--- a/winnet.c
+++ b/winnet.c
@@ -365,6 +365,7 @@ SockAddr sk_namelookup(char *host, char **canonicalname)
 SockAddr sk_nonamelookup(char *host)
 {
     SockAddr ret = smalloc(sizeof(struct SockAddr_tag));
+    ret->error = NULL;
     ret->family = AF_UNSPEC;
     strncpy(ret->hostname, host, lenof(ret->hostname));
     ret->hostname[lenof(ret->hostname)-1] = '\0';