]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
greybus: es2: move ap_disconnect() below ap_probe()
authorViresh Kumar <viresh.kumar@linaro.org>
Thu, 21 Apr 2016 06:01:16 +0000 (11:31 +0530)
committerGreg Kroah-Hartman <gregkh@google.com>
Thu, 21 Apr 2016 07:11:15 +0000 (16:11 +0900)
This makes it more readable, as the functions are present in this order
in the structure as well. Also keeping these two makes more sense.

Tested by removing the gb-es2.ko module on both EVT1.5 and qemu with
gbsim.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/es2.c

index 0a29708cdb74dc7d9a1292facebc508dc0cbb5d8..1cef13d3fb5d9c623f4ec3ae7fd4e7281b2f57a8 100644 (file)
@@ -690,19 +690,6 @@ static void es2_destroy(struct es2_ap_dev *es2)
        usb_put_dev(udev);
 }
 
-static void ap_disconnect(struct usb_interface *interface)
-{
-       struct es2_ap_dev *es2 = usb_get_intfdata(interface);
-       int i;
-
-       gb_hd_del(es2->hd);
-
-       for (i = 0; i < NUM_BULKS; ++i)
-               es2_cport_in_disable(es2, &es2->cport_in[i]);
-
-       es2_destroy(es2);
-}
-
 static void cport_in_callback(struct urb *urb)
 {
        struct gb_host_device *hd = urb->context;
@@ -1083,6 +1070,19 @@ static int ap_probe(struct usb_interface *interface,
        return retval;
 }
 
+static void ap_disconnect(struct usb_interface *interface)
+{
+       struct es2_ap_dev *es2 = usb_get_intfdata(interface);
+       int i;
+
+       gb_hd_del(es2->hd);
+
+       for (i = 0; i < NUM_BULKS; ++i)
+               es2_cport_in_disable(es2, &es2->cport_in[i]);
+
+       es2_destroy(es2);
+}
+
 static struct usb_driver es2_ap_driver = {
        .name =         "es2_ap_driver",
        .probe =        ap_probe,