]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
pinctrl: max77620: add OF dependency
authorArnd Bergmann <arnd@arndb.de>
Fri, 28 Oct 2016 08:19:05 +0000 (10:19 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Sat, 29 Oct 2016 08:30:16 +0000 (10:30 +0200)
Drivers using pinconf_generic_params tables cannot be built with
CONFIG_OF disabled:

drivers/pinctrl/pinctrl-max77620.c:53:44: error: array type has incomplete element type ‘struct pinconf_generic_params’
drivers/pinctrl/pinctrl-max77620.c:55:3: error: field name not in record or union initializer
drivers/pinctrl/pinctrl-max77620.c:55:3: note: (near initialization for ‘max77620_cfg_params’)
drivers/pinctrl/pinctrl-max77620.c:56:3: error: field name not in record or union initializer

This adds a dependency for max77620 to disallow that configuration.

Alternatively, we could rework the pinctrl infrastructure to make the
configuration valid for compile-testing.

Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>
Fixes: 453943dc8f45 ("mfd: Enable compile testing for max77620 and max77686")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/Kconfig

index 801fa8bb05e147cd382211d5e92f37e16bd558e5..3eea73937ce80a6ba5730e83279ff3318c51ba38 100644 (file)
@@ -223,7 +223,7 @@ config PINCTRL_COH901
 
 config PINCTRL_MAX77620
        tristate "MAX77620/MAX20024 Pincontrol support"
-       depends on MFD_MAX77620
+       depends on MFD_MAX77620 && OF
        select PINMUX
        select GENERIC_PINCONF
        help