If getaddrinfo() fails, it's not safe to dereference the struct addrinfo* it

passes back to us, so don't.

[originally from svn r5167]

diff --git a/unix/uxnet.c b/unix/uxnet.c
index b7c20cff4c8c0a801a2697e7cf3ec032edf040ae..8804b09bc5004fadb1e53638dc2e3151f16e678a 100644 (file)
--- a/unix/uxnet.c
+++ b/unix/uxnet.c
@@ -713,8 +713,10 @@ Socket sk_newlistener(char *srcaddr, int port, Plug plug, int local_host_only, i
         hints.ai_next = NULL;
         sprintf(portstr, "%d", port);
         retcode = getaddrinfo(srcaddr, portstr, &hints, &ai);
-        addr = ai->ai_addr;
-        addrlen = ai->ai_addrlen;
+       if (retcode = 0) {
+           addr = ai->ai_addr;
+           addrlen = ai->ai_addrlen;
+       }
 #else
         memset(&a,'\0',sizeof(struct sockaddr_in));
         a.sin_family = AF_INET;