]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
x86/vector: Remove pointless pointer checks
authorThomas Gleixner <tglx@linutronix.de>
Wed, 13 Sep 2017 21:29:35 +0000 (23:29 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 25 Sep 2017 18:51:55 +0000 (20:51 +0200)
The info pointer checks in assign_irq_vector_policy() are pointless because
the pointer cannot be NULL, otherwise the calling code would already crash.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Tested-by: Yu Chen <yu.c.chen@intel.com>
Acked-by: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Alok Kataria <akataria@vmware.com>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Rui Zhang <rui.zhang@intel.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Len Brown <lenb@kernel.org>
Link: https://lkml.kernel.org/r/20170913213154.859484148@linutronix.de
arch/x86/kernel/apic/vector.c

index d6feb9ca8f52ff24ffd06eac586bbff7fe44bba5..22cae8888e9720586d25fb4f9f4fd964c8163b69 100644 (file)
@@ -254,7 +254,7 @@ static int assign_irq_vector_policy(int irq, int node,
                                    struct irq_alloc_info *info,
                                    struct irq_data *irqd)
 {
-       if (info && info->mask)
+       if (info->mask)
                return assign_irq_vector(irq, apicd, info->mask, irqd);
        if (node != NUMA_NO_NODE &&
            assign_irq_vector(irq, apicd, cpumask_of_node(node), irqd) == 0)