]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
x86/kgbd: Use NMI_VECTOR not APIC_DM_NMI
authorThomas Gleixner <tglx@linutronix.de>
Mon, 22 Jul 2019 18:47:06 +0000 (20:47 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 25 Jul 2019 14:11:56 +0000 (16:11 +0200)
apic->send_IPI_allbutself() takes a vector number as argument.

APIC_DM_NMI is clearly not a vector number. It's defined to 0x400 which is
outside the vector space.

Use NMI_VECTOR instead as that's what it is intended to be.

Fixes: 82da3ff89dc2 ("x86: kgdb support")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20190722105218.855189979@linutronix.de
arch/x86/kernel/kgdb.c

index 23297ea64f5fc2086415f0181c269b5852ab730d..a53dfb09880f21f9b9150b8648df79bdd03a81d1 100644 (file)
@@ -416,7 +416,7 @@ static void kgdb_disable_hw_debug(struct pt_regs *regs)
  */
 void kgdb_roundup_cpus(void)
 {
-       apic->send_IPI_allbutself(APIC_DM_NMI);
+       apic->send_IPI_allbutself(NMI_VECTOR);
 }
 #endif