]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
usb: host: ehci-sched: move constants to right
authorGeyslan G. Bem <geyslan@gmail.com>
Tue, 26 Jan 2016 01:45:11 +0000 (22:45 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Feb 2016 21:44:05 +0000 (13:44 -0800)
This patch moves the constants to right.

Tested by compilation only.
Caught by coccinelle:
scripts/coccinelle/misc/compare_const_fl.cocci

Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ehci-sched.c

index 74c2023763adfe8d766fd1c9572255688904c61e..f4a94d443abef1f56cc0c8d292e9912d7033afc3 100644 (file)
@@ -330,7 +330,7 @@ static int __maybe_unused same_tt(struct usb_device *dev1,
  */
 static inline unsigned char tt_start_uframe(struct ehci_hcd *ehci, __hc32 mask)
 {
-       unsigned char smask = QH_SMASK & hc32_to_cpu(ehci, mask);
+       unsigned char smask = hc32_to_cpu(ehci, mask) & QH_SMASK;
        if (!smask) {
                ehci_err(ehci, "invalid empty smask!\n");
                /* uframe 7 can't have bw so this will indicate failure */
@@ -409,11 +409,11 @@ static int tt_available (
                 * must be empty, so as to not illegally delay
                 * already scheduled transactions
                 */
-               if (125 < usecs) {
+               if (usecs > 125) {
                        int ufs = (usecs / 125);
 
                        for (i = uframe; i < (uframe + ufs) && i < 8; i++)
-                               if (0 < tt_usecs[i])
+                               if (tt_usecs[i] > 0)
                                        return 0;
                }