]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/ttm: Initialize local lists in ttm_bo_bulk_move_helper
authorMichel Dänzer <michel.daenzer@amd.com>
Tue, 28 Aug 2018 16:56:29 +0000 (18:56 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 29 Aug 2018 17:35:59 +0000 (12:35 -0500)
The first parameter of list_cut_position() must point to an initialized
list.

Noticed thanks to KASAN pointing out something's fishy here.

Fixes: "drm/ttm: add bulk move function on LRU"
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/ttm/ttm_bo.c

index 39d9d559b2794f47921973af4f3e14e7ea23d666..35d53d81f4868a4706c4d8fc34cb2775d4abfffe 100644 (file)
@@ -250,7 +250,8 @@ EXPORT_SYMBOL(ttm_bo_move_to_lru_tail);
 static void ttm_bo_bulk_move_helper(struct ttm_lru_bulk_move_pos *pos,
                                    struct list_head *lru, bool is_swap)
 {
-       struct list_head entries, before;
+       LIST_HEAD(entries);
+       LIST_HEAD(before);
        struct list_head *list1, *list2;
 
        list1 = is_swap ? &pos->last->swap : &pos->last->lru;