]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
pNFS/flexfiles: Check the result of nfs4_pnfs_ds_connect
authorTrond Myklebust <trond.myklebust@primarydata.com>
Thu, 20 Apr 2017 18:33:06 +0000 (14:33 -0400)
committerTrond Myklebust <trond.myklebust@primarydata.com>
Thu, 20 Apr 2017 18:37:37 +0000 (14:37 -0400)
The check in nfs4_ff_layout_prepare_ds() seems to be missing.

Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Fixes: a33e4b036d461 ("pNFS: return status from nfs4_pnfs_ds_connect")
Cc: Weston Andros Adamson <dros@primarydata.com>
Cc: stable@vger.kernel.org # v4.11
fs/nfs/flexfilelayout/flexfilelayoutdev.c

index 8ca9cc6655613ad23541d96767094bf34723d952..6df7a0cf566015378aa3f76c480115675454297d 100644 (file)
@@ -421,7 +421,7 @@ nfs4_ff_layout_prepare_ds(struct pnfs_layout_segment *lseg, u32 ds_idx,
                             mirror->mirror_ds->ds_versions[0].minor_version);
 
        /* connect success, check rsize/wsize limit */
-       if (ds->ds_clp) {
+       if (!status) {
                max_payload =
                        nfs_block_size(rpc_max_payload(ds->ds_clp->cl_rpcclient),
                                       NULL);