]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ACPI / scan: Send change uevent with offine environmental data
authorLee, Chun-Yi <joeyli.kernel@gmail.com>
Tue, 20 Mar 2018 05:51:26 +0000 (13:51 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 20 Mar 2018 09:33:51 +0000 (10:33 +0100)
In current design of ACPI container offline, Kernel emits
KOBJ_CHANGE uevent to user space to indidate that the ejection of
the container was triggered by platform. (caa73ea15 patch)

A pure KOBJ_CHANGE uevent is not enough for user space to identify
the purpose. For example, a "udevadm trigger" command can also
be used to emit change event to all udev rules. A udev rule can not
identify that the event is from kernel for offline or from udevadm
for other purpose. Then the offline action in udev rule may also be
triggered by udevadm tool.

So, similar to the change uevent of dock, kernel sends the
KOBJ_CHANGE uevent with a offline environmental data to indicate
purpose. It's useful by udev rule for using ENV{EVENT} filter.

Acked-by: Michal Hocko <mhocko@suse.com>
Tested-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/scan.c

index 8e63d937babb0de9d85cac007a03a6eda1258307..490498eca0d3db7d6af5794de7636f43695e8e2e 100644 (file)
@@ -116,6 +116,7 @@ bool acpi_scan_is_offline(struct acpi_device *adev, bool uevent)
 {
        struct acpi_device_physical_node *pn;
        bool offline = true;
+       char *envp[] = { "EVENT=offline", NULL };
 
        /*
         * acpi_container_offline() calls this for all of the container's
@@ -126,7 +127,7 @@ bool acpi_scan_is_offline(struct acpi_device *adev, bool uevent)
        list_for_each_entry(pn, &adev->physical_node_list, node)
                if (device_supports_offline(pn->dev) && !pn->dev->offline) {
                        if (uevent)
-                               kobject_uevent(&pn->dev->kobj, KOBJ_CHANGE);
+                               kobject_uevent_env(&pn->dev->kobj, KOBJ_CHANGE, envp);
 
                        offline = false;
                        break;