]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/qxl: Replace drm_gem_object_reference/unreference() with _get/put()
authorSantha Meena Ramamoorthy <santhameena13@gmail.com>
Tue, 20 Mar 2018 18:29:27 +0000 (11:29 -0700)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 21 Mar 2018 08:19:56 +0000 (09:19 +0100)
Replace drm_gem_object_reference/unreference function with *_get/put()
suffixes, because it is shorter and consistent with the kernel
kref_get/put() functions. The following Coccinelle script was used:

@@
expression e;
@@

(
-drm_gem_object_reference(e);
+drm_gem_object_get(e);
|
-drm_gem_object_unreference(e);
+drm_gem_object_put(e);
|
-drm_gem_object_unreference_unlocked(e);
+drm_gem_object_put_unlocked(e);
)

Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/1521570567-22519-1-git-send-email-santhameena13@gmail.com
drivers/gpu/drm/qxl/qxl_display.c
drivers/gpu/drm/qxl/qxl_dumb.c
drivers/gpu/drm/qxl/qxl_fb.c
drivers/gpu/drm/qxl/qxl_gem.c
drivers/gpu/drm/qxl/qxl_ioctl.c
drivers/gpu/drm/qxl/qxl_object.c

index 9a9214ae0fb50de379c68c433da3bf8337c3093a..ecb35ed0eac89ea3c5113a674bbd17383070a75d 100644 (file)
@@ -309,7 +309,7 @@ void qxl_user_framebuffer_destroy(struct drm_framebuffer *fb)
        struct qxl_bo *bo = gem_to_qxl_bo(qxl_fb->obj);
 
        WARN_ON(bo->shadow);
-       drm_gem_object_unreference_unlocked(qxl_fb->obj);
+       drm_gem_object_put_unlocked(qxl_fb->obj);
        drm_framebuffer_cleanup(fb);
        kfree(qxl_fb);
 }
@@ -1215,7 +1215,7 @@ qxl_user_framebuffer_create(struct drm_device *dev,
        ret = qxl_framebuffer_init(dev, qxl_fb, mode_cmd, obj, &qxl_fb_funcs);
        if (ret) {
                kfree(qxl_fb);
-               drm_gem_object_unreference_unlocked(obj);
+               drm_gem_object_put_unlocked(obj);
                return NULL;
        }
 
index 11085ab0137425cae14eda185a4ce86df487e21e..c666b89eed5d12d77c3be77ac3c23290895a9424 100644 (file)
@@ -82,6 +82,6 @@ int qxl_mode_dumb_mmap(struct drm_file *file_priv,
                return -ENOENT;
        qobj = gem_to_qxl_bo(gobj);
        *offset_p = qxl_bo_mmap_offset(qobj);
-       drm_gem_object_unreference_unlocked(gobj);
+       drm_gem_object_put_unlocked(gobj);
        return 0;
 }
index 23af3e352673e3b3e4712c68544e8c1d35fa9d00..338891401f3530864ce18780f8f4d37b2aea3860 100644 (file)
@@ -95,7 +95,7 @@ static void qxlfb_destroy_pinned_object(struct drm_gem_object *gobj)
        qxl_bo_kunmap(qbo);
        qxl_bo_unpin(qbo);
 
-       drm_gem_object_unreference_unlocked(gobj);
+       drm_gem_object_put_unlocked(gobj);
 }
 
 int qxl_get_handle_for_primary_fb(struct qxl_device *qdev,
@@ -316,11 +316,11 @@ static int qxlfb_create(struct qxl_fbdev *qfbdev,
                qxl_bo_unpin(qbo);
        }
        if (fb && ret) {
-               drm_gem_object_unreference_unlocked(gobj);
+               drm_gem_object_put_unlocked(gobj);
                drm_framebuffer_cleanup(fb);
                kfree(fb);
        }
-       drm_gem_object_unreference_unlocked(gobj);
+       drm_gem_object_put_unlocked(gobj);
        return ret;
 }
 
index 85f546719adb073b8da05d4beeb49779c052d28a..f5c1e7872e920d3a0a3c9e7ec0b0bcfa5779def8 100644 (file)
@@ -98,7 +98,7 @@ int qxl_gem_object_create_with_handle(struct qxl_device *qdev,
                return r;
        /* drop reference from allocate - handle holds it now */
        *qobj = gem_to_qxl_bo(gobj);
-       drm_gem_object_unreference_unlocked(gobj);
+       drm_gem_object_put_unlocked(gobj);
        return 0;
 }
 
index e8c0b10372301784956c9c32282041f9424102bf..e238a1a2eca1cf47c88248ff3b7419579055a5bc 100644 (file)
@@ -121,7 +121,7 @@ static int qxlhw_handle_to_bo(struct drm_file *file_priv, uint64_t handle,
        qobj = gem_to_qxl_bo(gobj);
 
        ret = qxl_release_list_add(release, qobj);
-       drm_gem_object_unreference_unlocked(gobj);
+       drm_gem_object_put_unlocked(gobj);
        if (ret)
                return ret;
 
@@ -343,7 +343,7 @@ static int qxl_update_area_ioctl(struct drm_device *dev, void *data,
        qxl_bo_unreserve(qobj);
 
 out:
-       drm_gem_object_unreference_unlocked(gobj);
+       drm_gem_object_put_unlocked(gobj);
        return ret;
 }
 
index f6b80fe47d1f76f748895042cbd506ddd40e93eb..e9fb0ab6ceeab660d52bf7a630869ac4b91b34d1 100644 (file)
@@ -211,13 +211,13 @@ void qxl_bo_unref(struct qxl_bo **bo)
        if ((*bo) == NULL)
                return;
 
-       drm_gem_object_unreference_unlocked(&(*bo)->gem_base);
+       drm_gem_object_put_unlocked(&(*bo)->gem_base);
        *bo = NULL;
 }
 
 struct qxl_bo *qxl_bo_ref(struct qxl_bo *bo)
 {
-       drm_gem_object_reference(&bo->gem_base);
+       drm_gem_object_get(&bo->gem_base);
        return bo;
 }
 
@@ -318,7 +318,7 @@ void qxl_bo_force_delete(struct qxl_device *qdev)
                list_del_init(&bo->list);
                mutex_unlock(&qdev->gem.mutex);
                /* this should unref the ttm bo */
-               drm_gem_object_unreference_unlocked(&bo->gem_base);
+               drm_gem_object_put_unlocked(&bo->gem_base);
        }
 }