]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
PCI: mobiveil: Move IRQ chained handler setup out of DT parse
authorHou Zhiqiang <Zhiqiang.Hou@nxp.com>
Fri, 5 Jul 2019 09:56:37 +0000 (17:56 +0800)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Mon, 8 Jul 2019 11:28:44 +0000 (12:28 +0100)
The irq_set_chained_handler_and_data() call is not dependent on device
tree firmware so it should be moved out of the DT parsing function for
clarity.

Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
[lorenzo.pieralisi@arm.com: rewritten commit log]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Minghuan Lian <Minghuan.Lian@nxp.com>
Reviewed-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
drivers/pci/controller/pcie-mobiveil.c

index 8f92f05c9211b90f465af85b3d9160f1132052fa..cdf15cca526ead614dd449b825775babc8833580 100644 (file)
@@ -446,8 +446,6 @@ static int mobiveil_pcie_parse_dt(struct mobiveil_pcie *pcie)
                return -ENODEV;
        }
 
-       irq_set_chained_handler_and_data(pcie->irq, mobiveil_pcie_isr, pcie);
-
        return 0;
 }
 
@@ -872,6 +870,8 @@ static int mobiveil_pcie_probe(struct platform_device *pdev)
                goto error;
        }
 
+       irq_set_chained_handler_and_data(pcie->irq, mobiveil_pcie_isr, pcie);
+
        ret = devm_request_pci_bus_resources(dev, &pcie->resources);
        if (ret)
                goto error;