]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
usb: dwc2: Set lpm mode parameters depend on HW configuration
authorMinas Harutyunyan <minas.harutyunyan@synopsys.com>
Mon, 4 Mar 2019 13:08:07 +0000 (17:08 +0400)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Fri, 3 May 2019 06:13:49 +0000 (09:13 +0300)
If core not supported lpm, i.e. BCM2835 then confusing warnings seen
in log.

To avoid these warnings, added function dwc2_set_param_lpm() to set
lpm and other lpm related parameters based on lpm support by core.

Signed-off-by: Minas Harutyunyan <hminas@synopsys.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/dwc2/params.c

index 442113246cba6d2c9a791876087c7f715068edc9..6900eea575267640b10b50e4a6717e10c42ea378 100644 (file)
@@ -285,6 +285,23 @@ static void dwc2_set_param_power_down(struct dwc2_hsotg *hsotg)
        hsotg->params.power_down = val;
 }
 
+static void dwc2_set_param_lpm(struct dwc2_hsotg *hsotg)
+{
+       struct dwc2_core_params *p = &hsotg->params;
+
+       p->lpm = hsotg->hw_params.lpm_mode;
+       if (p->lpm) {
+               p->lpm_clock_gating = true;
+               p->besl = true;
+               p->hird_threshold_en = true;
+               p->hird_threshold = 4;
+       } else {
+               p->lpm_clock_gating = false;
+               p->besl = false;
+               p->hird_threshold_en = false;
+       }
+}
+
 /**
  * dwc2_set_default_params() - Set all core parameters to their
  * auto-detected default values.
@@ -303,6 +320,7 @@ static void dwc2_set_default_params(struct dwc2_hsotg *hsotg)
        dwc2_set_param_speed(hsotg);
        dwc2_set_param_phy_utmi_width(hsotg);
        dwc2_set_param_power_down(hsotg);
+       dwc2_set_param_lpm(hsotg);
        p->phy_ulpi_ddr = false;
        p->phy_ulpi_ext_vbus = false;
 
@@ -315,11 +333,6 @@ static void dwc2_set_default_params(struct dwc2_hsotg *hsotg)
        p->reload_ctl = (hw->snpsid >= DWC2_CORE_REV_2_92a);
        p->uframe_sched = true;
        p->external_id_pin_ctl = false;
-       p->lpm = true;
-       p->lpm_clock_gating = true;
-       p->besl = true;
-       p->hird_threshold_en = true;
-       p->hird_threshold = 4;
        p->ipg_isoc_en = false;
        p->service_interval = false;
        p->max_packet_count = hw->max_packet_count;