]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
mISDN: l1oip_core: replace _manual_ swap with swap macro
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Fri, 3 Nov 2017 16:52:45 +0000 (11:52 -0500)
committerDavid S. Miller <davem@davemloft.net>
Sun, 5 Nov 2017 13:24:15 +0000 (22:24 +0900)
Make use of the swap macro and remove unnecessary variables skb and cnt.
This makes the code easier to read and maintain.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/mISDN/l1oip_core.c

index b5d590e378ace0534acf2c4613d3b65fa768a0b1..e3654782a3e2f330a481e6f26f6a9f65b5b56eda 100644 (file)
@@ -440,14 +440,8 @@ l1oip_socket_recv(struct l1oip *hc, u8 remotecodec, u8 channel, u16 timebase,
 
 #ifdef REORDER_DEBUG
                if (hc->chan[channel].disorder_flag) {
-                       struct sk_buff *skb;
-                       int cnt;
-                       skb = hc->chan[channel].disorder_skb;
-                       hc->chan[channel].disorder_skb = nskb;
-                       nskb = skb;
-                       cnt = hc->chan[channel].disorder_cnt;
-                       hc->chan[channel].disorder_cnt = rx_counter;
-                       rx_counter = cnt;
+                       swap(hc->chan[channel].disorder_skb, nskb);
+                       swap(hc->chan[channel].disorder_cnt, rx_counter);
                }
                hc->chan[channel].disorder_flag ^= 1;
                if (nskb)