]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
PCI: pciehp: Remove useless pciehp_get_latch_status() calls
authorBjorn Helgaas <bhelgaas@google.com>
Wed, 7 Sep 2016 22:50:30 +0000 (17:50 -0500)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 14 Sep 2016 19:25:05 +0000 (14:25 -0500)
Long ago, we updated a "switch_save" field based on the latch status.  But
switch_save was unused, and ed6cbcf2ac70 ("[PATCH] pciehp: miscellaneous
cleanups") removed it.

We no longer use the latch status, so remove calls to
pciehp_get_latch_status().  No functional change intended.

Tested-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
drivers/pci/hotplug/pciehp_ctrl.c

index bf50f268117829fc0728300fa690a88851fc4b02..efe69e879455cbd19ac4733d863d81d6666c3a7b 100644 (file)
@@ -389,7 +389,6 @@ static void interrupt_event_handler(struct work_struct *work)
 int pciehp_enable_slot(struct slot *p_slot)
 {
        u8 getstatus = 0;
-       int rc;
        struct controller *ctrl = p_slot->ctrl;
 
        pciehp_get_adapter_status(p_slot, &getstatus);
@@ -415,13 +414,7 @@ int pciehp_enable_slot(struct slot *p_slot)
                }
        }
 
-       pciehp_get_latch_status(p_slot, &getstatus);
-
-       rc = board_added(p_slot);
-       if (rc)
-               pciehp_get_latch_status(p_slot, &getstatus);
-
-       return rc;
+       return board_added(p_slot);
 }
 
 /*