]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
panel: rocktech: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Jun 2019 11:57:17 +0000 (13:57 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 13 Jun 2019 13:10:02 +0000 (15:10 +0200)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: "Guido Günther" <agx@sigxcpu.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Guido Günther <agx@sigxcpu.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20190613115717.GB26335@kroah.com
drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c

index d88ea8da2ec2643f832b27ce0ada2aa447d12499..6dcb692c47017b8c4c729419d50c3471d56f7d03 100644 (file)
@@ -257,20 +257,12 @@ static int allpixelson_set(void *data, u64 val)
 DEFINE_SIMPLE_ATTRIBUTE(allpixelson_fops, NULL,
                        allpixelson_set, "%llu\n");
 
-static int jh057n_debugfs_init(struct jh057n *ctx)
+static void jh057n_debugfs_init(struct jh057n *ctx)
 {
-       struct dentry *f;
-
        ctx->debugfs = debugfs_create_dir(DRV_NAME, NULL);
-       if (!ctx->debugfs)
-               return -ENOMEM;
 
-       f = debugfs_create_file("allpixelson", 0600,
-                               ctx->debugfs, ctx, &allpixelson_fops);
-       if (!f)
-               return -ENOMEM;
-
-       return 0;
+       debugfs_create_file("allpixelson", 0600, ctx->debugfs, ctx,
+                           &allpixelson_fops);
 }
 
 static void jh057n_debugfs_remove(struct jh057n *ctx)