platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure

Add a module parameter which when enabled, will check on resume, if the
last S0ix attempt was successful. If not, the driver would warn and provide
helpful debug information (which gets latched during the failed suspend
attempt) to debug the S0ix failure.

This information is very useful to debug S0ix failures. Specially since
the latched debug information will be lost (over-written) if the system
attempts to go into runtime (or imminent) S0ix again after that failed
suspend attempt.

Signed-off-by: Rajat Jain <rajatja@google.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
index 153e79cc4d5b2b62618444a6d74f8415db78d752..1d902230ba611535c5ce0d85a6ac7b7b05e21040 100644 (file)
--- a/drivers/platform/x86/intel_pmc_core.c
+++ b/drivers/platform/x86/intel_pmc_core.c
@@ -20,6 +20,7 @@
 #include <linux/module.h>
 #include <linux/pci.h>
 #include <linux/platform_device.h>
+#include <linux/suspend.h>
 #include <linux/uaccess.h>
 
 #include <asm/cpu_device_id.h>
@@ -919,9 +920,113 @@ static int pmc_core_remove(struct platform_device *pdev)
        return 0;
 }
 
+#ifdef CONFIG_PM_SLEEP
+
+static bool warn_on_s0ix_failures;
+module_param(warn_on_s0ix_failures, bool, 0644);
+MODULE_PARM_DESC(warn_on_s0ix_failures, "Check and warn for S0ix failures");
+
+static int pmc_core_suspend(struct device *dev)
+{
+       struct pmc_dev *pmcdev = dev_get_drvdata(dev);
+
+       pmcdev->check_counters = false;
+
+       /* No warnings on S0ix failures */
+       if (!warn_on_s0ix_failures)
+               return 0;
+
+       /* Check if the syspend will actually use S0ix */
+       if (pm_suspend_via_firmware())
+               return 0;
+
+       /* Save PC10 residency for checking later */
+       if (rdmsrl_safe(MSR_PKG_C10_RESIDENCY, &pmcdev->pc10_counter))
+               return -EIO;
+
+       /* Save S0ix residency for checking later */
+       if (pmc_core_dev_state_get(pmcdev, &pmcdev->s0ix_counter))
+               return -EIO;
+
+       pmcdev->check_counters = true;
+       return 0;
+}
+
+static inline bool pmc_core_is_pc10_failed(struct pmc_dev *pmcdev)
+{
+       u64 pc10_counter;
+
+       if (rdmsrl_safe(MSR_PKG_C10_RESIDENCY, &pc10_counter))
+               return false;
+
+       if (pc10_counter == pmcdev->pc10_counter)
+               return true;
+
+       return false;
+}
+
+static inline bool pmc_core_is_s0ix_failed(struct pmc_dev *pmcdev)
+{
+       u64 s0ix_counter;
+
+       if (pmc_core_dev_state_get(pmcdev, &s0ix_counter))
+               return false;
+
+       if (s0ix_counter == pmcdev->s0ix_counter)
+               return true;
+
+       return false;
+}
+
+static int pmc_core_resume(struct device *dev)
+{
+       struct pmc_dev *pmcdev = dev_get_drvdata(dev);
+       const struct pmc_bit_map **maps = pmcdev->map->slps0_dbg_maps;
+       int offset = pmcdev->map->slps0_dbg_offset;
+       const struct pmc_bit_map *map;
+       u32 data;
+
+       if (!pmcdev->check_counters)
+               return 0;
+
+       if (!pmc_core_is_s0ix_failed(pmcdev))
+               return 0;
+
+       if (pmc_core_is_pc10_failed(pmcdev)) {
+               /* S0ix failed because of PC10 entry failure */
+               dev_info(dev, "CPU did not enter PC10!!! (PC10 cnt=0x%llx)\n",
+                        pmcdev->pc10_counter);
+               return 0;
+       }
+
+       /* The real interesting case - S0ix failed - lets ask PMC why. */
+       dev_warn(dev, "CPU did not enter SLP_S0!!! (S0ix cnt=%llu)\n",
+                pmcdev->s0ix_counter);
+       while (*maps) {
+               map = *maps;
+               data = pmc_core_reg_read(pmcdev, offset);
+               offset += 4;
+               while (map->name) {
+                       dev_dbg(dev, "SLP_S0_DBG: %-32s\tState: %s\n",
+                               map->name,
+                               data & map->bit_mask ? "Yes" : "No");
+                       map++;
+               }
+               maps++;
+       }
+       return 0;
+}
+
+#endif
+
+static const struct dev_pm_ops pmc_core_pm_ops = {
+       SET_LATE_SYSTEM_SLEEP_PM_OPS(pmc_core_suspend, pmc_core_resume)
+};
+
 static struct platform_driver pmc_core_driver = {
        .driver = {
                .name = "intel_pmc_core",
+               .pm = &pmc_core_pm_ops,
        },
        .probe = pmc_core_probe,
        .remove = pmc_core_remove,

diff --git a/drivers/platform/x86/intel_pmc_core.h b/drivers/platform/x86/intel_pmc_core.h
index 88d9c0653a5fc721cf2624f3ee472a93e8d87c35..fdee5772e5322a9112a3c40d0f7cf494841f98ee 100644 (file)
--- a/drivers/platform/x86/intel_pmc_core.h
+++ b/drivers/platform/x86/intel_pmc_core.h
@@ -241,6 +241,9 @@ struct pmc_reg_map {
  * @pmc_xram_read_bit: flag to indicate whether PMC XRAM shadow registers
  *                     used to read MPHY PG and PLL status are available
  * @mutex_lock:                mutex to complete one transcation
+ * @check_counters:    On resume, check if counters are getting incremented
+ * @pc10_counter:      PC10 residency counter
+ * @s0ix_counter:      S0ix residency (step adjusted)
  *
  * pmc_dev contains info about power management controller device.
  */
@@ -253,6 +256,10 @@ struct pmc_dev {
 #endif /* CONFIG_DEBUG_FS */
        int pmc_xram_read_bit;
        struct mutex lock; /* generic mutex lock for PMC Core */
+
+       bool check_counters; /* Check for counter increments on resume */
+       u64 pc10_counter;
+       u64 s0ix_counter;
 };
 
 #endif /* PMC_CORE_H */