]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
xprtrdma: Remove ro_unmap_safe
authorChuck Lever <chuck.lever@oracle.com>
Mon, 9 Oct 2017 16:03:42 +0000 (12:03 -0400)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Mon, 16 Oct 2017 17:51:27 +0000 (13:51 -0400)
Clean up: There are no remaining callers of this method.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
net/sunrpc/xprtrdma/fmr_ops.c
net/sunrpc/xprtrdma/frwr_ops.c
net/sunrpc/xprtrdma/xprt_rdma.h

index 6c7151341194635919e31b812223732c4436ba40..30bf713080f1e0d1fc06cdf3d2cc308485e795a6 100644 (file)
@@ -305,28 +305,9 @@ fmr_op_unmap_sync(struct rpcrdma_xprt *r_xprt, struct list_head *mws)
        }
 }
 
-/* Use a slow, safe mechanism to invalidate all memory regions
- * that were registered for "req".
- */
-static void
-fmr_op_unmap_safe(struct rpcrdma_xprt *r_xprt, struct rpcrdma_req *req,
-                 bool sync)
-{
-       struct rpcrdma_mw *mw;
-
-       while (!list_empty(&req->rl_registered)) {
-               mw = rpcrdma_pop_mw(&req->rl_registered);
-               if (sync)
-                       fmr_op_recover_mr(mw);
-               else
-                       rpcrdma_defer_mr_recovery(mw);
-       }
-}
-
 const struct rpcrdma_memreg_ops rpcrdma_fmr_memreg_ops = {
        .ro_map                         = fmr_op_map,
        .ro_unmap_sync                  = fmr_op_unmap_sync,
-       .ro_unmap_safe                  = fmr_op_unmap_safe,
        .ro_recover_mr                  = fmr_op_recover_mr,
        .ro_open                        = fmr_op_open,
        .ro_maxpages                    = fmr_op_maxpages,
index df062e086bdbbda8eb9ec724754937ea42134505..3053fb0f5cb3811e4a3e9585256019372f275888 100644 (file)
@@ -558,28 +558,9 @@ frwr_op_unmap_sync(struct rpcrdma_xprt *r_xprt, struct list_head *mws)
        goto unmap;
 }
 
-/* Use a slow, safe mechanism to invalidate all memory regions
- * that were registered for "req".
- */
-static void
-frwr_op_unmap_safe(struct rpcrdma_xprt *r_xprt, struct rpcrdma_req *req,
-                  bool sync)
-{
-       struct rpcrdma_mw *mw;
-
-       while (!list_empty(&req->rl_registered)) {
-               mw = rpcrdma_pop_mw(&req->rl_registered);
-               if (sync)
-                       frwr_op_recover_mr(mw);
-               else
-                       rpcrdma_defer_mr_recovery(mw);
-       }
-}
-
 const struct rpcrdma_memreg_ops rpcrdma_frwr_memreg_ops = {
        .ro_map                         = frwr_op_map,
        .ro_unmap_sync                  = frwr_op_unmap_sync,
-       .ro_unmap_safe                  = frwr_op_unmap_safe,
        .ro_recover_mr                  = frwr_op_recover_mr,
        .ro_open                        = frwr_op_open,
        .ro_maxpages                    = frwr_op_maxpages,
index e26a97d2f922fad2cc14aa11ea0cd4287d1c26b5..74e017477e72009e1732c63ca2f9d533a6cb960b 100644 (file)
@@ -473,8 +473,6 @@ struct rpcrdma_memreg_ops {
                                  struct rpcrdma_mw **);
        void            (*ro_unmap_sync)(struct rpcrdma_xprt *,
                                         struct list_head *);
-       void            (*ro_unmap_safe)(struct rpcrdma_xprt *,
-                                        struct rpcrdma_req *, bool);
        void            (*ro_recover_mr)(struct rpcrdma_mw *);
        int             (*ro_open)(struct rpcrdma_ia *,
                                   struct rpcrdma_ep *,