]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: gspca: sq930x: use GFP_KERNEL in sd_dq_callback()
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Wed, 20 Jun 2018 11:00:52 +0000 (07:00 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 12 Sep 2018 12:01:30 +0000 (08:01 -0400)
The context in which sd_dq_callback() is non atomic, there is even
msleep() at the end of the function. There is no need to use GFP_ATOMIC
here - use GFP_KERNEL instead.

Cc: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/usb/gspca/sq930x.c

index d7cbcf2b394794ac8d51529da921c2c51eb14065..e15b45f022e1b028ddad4a09599e6a90aaad75b7 100644 (file)
@@ -1044,7 +1044,7 @@ static void sd_dq_callback(struct gspca_dev *gspca_dev)
                        v4l2_ctrl_g_ctrl(sd->gain));
 
        gspca_dev->cam.bulk_nurbs = 1;
-       ret = usb_submit_urb(gspca_dev->urb[0], GFP_ATOMIC);
+       ret = usb_submit_urb(gspca_dev->urb[0], GFP_KERNEL);
        if (ret < 0)
                pr_err("sd_dq_callback() err %d\n", ret);