]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: cx25840: make array stds static const, reduces object code size
authorColin Ian King <colin.king@canonical.com>
Tue, 5 Sep 2017 11:03:32 +0000 (07:03 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sat, 23 Sep 2017 12:29:26 +0000 (08:29 -0400)
Don't populate the array syds on the stack, instead make it static const.
Makes the object code smaller by over 280 bytes:

Before:
   text    data     bss     dec     hex filename
  81451   12784     704   94939   172db cx25840-core.o

   text    data     bss     dec     hex filename
  81070   12880     704   94654   171be cx25840-core.o

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/i2c/cx25840/cx25840-core.c

index 39f51daa755866ebd4f86f719dbfff58f2d2c77d..f38bf819d80549b5c43ad3ed1883c0c36cfe26be 100644 (file)
@@ -1745,7 +1745,7 @@ static int cx25840_g_std(struct v4l2_subdev *sd, v4l2_std_id *std)
 {
        struct i2c_client *client = v4l2_get_subdevdata(sd);
 
-       v4l2_std_id stds[] = {
+       static const v4l2_std_id stds[] = {
                /* 0000 */ V4L2_STD_UNKNOWN,
 
                /* 0001 */ V4L2_STD_NTSC_M,