]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
KVM: s390: Fix printk on SIGP set arch
authorChristian Borntraeger <borntraeger@de.ibm.com>
Thu, 22 Jan 2009 13:20:27 +0000 (14:20 +0100)
committerAvi Kivity <avi@redhat.com>
Tue, 24 Mar 2009 09:03:07 +0000 (11:03 +0200)
KVM on s390 does not support the ESA/390 architecture. We refuse to
change the architecture mode and print a warning. This patch removes
the printk for several reasons:

o A malicious guest can flood host dmesg
o The old message had no newline
o there is no connection between the message and the failing guest

This patch simply removes the printk. We already set the condition
code to 3 - the guest knows that something went wrong.

Reported-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
arch/s390/kvm/sigp.c

index 2a01b9e02801f14afd348162f31679237cbd340a..f27dbedf086600280964164b207851c5f2f98dd2 100644 (file)
@@ -153,8 +153,6 @@ static int __sigp_set_arch(struct kvm_vcpu *vcpu, u32 parameter)
 
        switch (parameter & 0xff) {
        case 0:
-               printk(KERN_WARNING "kvm: request to switch to ESA/390 mode"
-                                                       " not supported");
                rc = 3; /* not operational */
                break;
        case 1: