]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
[media] media: pci: meye: set error code on failures
authorPan Bian <bianpan2016@163.com>
Sun, 4 Dec 2016 05:40:06 +0000 (03:40 -0200)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 3 Feb 2017 10:01:30 +0000 (08:01 -0200)
The value of return variable ret is 0 on some error paths, for example,
when pci_resource_start() returns a NULL pointer. 0 means no error in
this context, which is contrary to the fact. This patch fixes the bug.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189011

Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/pci/meye/meye.c

index 6274a9c5be470c27e48717c748c4a23fa3901300..9c4a024745de055571c6696daa4f4caf6cdb0c0a 100644 (file)
@@ -1659,6 +1659,7 @@ static int meye_probe(struct pci_dev *pcidev, const struct pci_device_id *ent)
                goto outenabledev;
        }
 
+       ret = -EIO;
        mchip_adr = pci_resource_start(meye.mchip_dev,0);
        if (!mchip_adr) {
                v4l2_err(v4l2_dev, "meye: mchip has no device base address\n");