]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
oradax: Fix return value check in dax_attach()
authorWei Yongjun <weiyongjun1@huawei.com>
Sat, 27 Jan 2018 08:10:59 +0000 (08:10 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 29 Jan 2018 19:28:48 +0000 (14:28 -0500)
In case of error, the function class_create() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().

Fixes: dd0273284c74 ("sparc64: Oracle DAX driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/sbus/char/oradax.c

index 10452ae18ef126e2fae657848fdf88e9fe14b113..03dc047392259253d885467f87333bf7ee3c73c2 100644 (file)
@@ -336,9 +336,9 @@ static int __init dax_attach(void)
        }
 
        cl = class_create(THIS_MODULE, DAX_NAME);
-       if (cl == NULL) {
+       if (IS_ERR(cl)) {
                dax_err("class_create failed");
-               ret = -ENXIO;
+               ret = PTR_ERR(cl);
                goto class_error;
        }