]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
iommu/vt-d: Missing checks for pasid tables if allocation fails
authorLu Baolu <baolu.lu@linux.intel.com>
Fri, 3 Nov 2017 16:51:32 +0000 (10:51 -0600)
committerAlex Williamson <alex.williamson@redhat.com>
Fri, 3 Nov 2017 16:51:32 +0000 (10:51 -0600)
intel_svm_alloc_pasid_tables() might return an error but never be
checked by the callers. Later when intel_svm_bind_mm() is called,
there are no checks for valid pasid tables before enabling them.

Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: Liu, Yi L <yi.l.liu@intel.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
drivers/iommu/intel-svm.c

index f6697e55c2d44f96baa52827af4e90be0548b71f..43280ca282df475464b81cb6a559bcbe369cfc6f 100644 (file)
@@ -292,7 +292,7 @@ int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_
        int pasid_max;
        int ret;
 
-       if (WARN_ON(!iommu))
+       if (WARN_ON(!iommu || !iommu->pasid_table))
                return -EINVAL;
 
        if (dev_is_pci(dev)) {