]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
parisc: Ratelimit dino stuck interrupt warnings
authorHelge Deller <deller@gmx.de>
Sun, 7 Oct 2018 21:28:45 +0000 (23:28 +0200)
committerHelge Deller <deller@gmx.de>
Wed, 17 Oct 2018 06:18:01 +0000 (08:18 +0200)
While playing with qemu with an emulated RT8139cp NIC, I faced lots of
the following warnings:
Dino 0x00810000: stuck interrupt 2

This patch ratelimits this warning and reports back that the IRQ was
handled.

Signed-off-by: Helge Deller <deller@gmx.de>
drivers/parisc/dino.c

index ac646d42b3003c3c0b5272553d211661f177353f..dfeea458a789ebf5d49c21e89c1ca79ef63767e9 100644 (file)
@@ -396,9 +396,8 @@ static irqreturn_t dino_isr(int irq, void *intr_dev)
        if (mask) {
                if (--ilr_loop > 0)
                        goto ilr_again;
-               printk(KERN_ERR "Dino 0x%px: stuck interrupt %d\n",
+               pr_warn_ratelimited("Dino 0x%px: stuck interrupt %d\n",
                       dino_dev->hba.base_addr, mask);
-               return IRQ_NONE;
        }
        return IRQ_HANDLED;
 }