]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: ov5640: Fix check for PLL1 exceeding max allowed rate
authorAdam Ford <aford173@gmail.com>
Tue, 29 Oct 2019 12:42:11 +0000 (13:42 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Sat, 4 Jan 2020 07:08:58 +0000 (08:08 +0100)
The variable _rate is by ov5640_compute_sys_clk() which returns
zero if the PLL exceeds 1GHz.  Unfortunately, the check to see
if the max PLL1 output is checking 'rate' and not '_rate' and
'rate' does not ever appear to be 0.

This patch changes the check against the returned value of
'_rate' to determine if the PLL1 output exceeds 1GHz.

Fixes: aa2882481cad ("media: ov5640: Adjust the clock based on the expected rate")
Signed-off-by: Adam Ford <aford173@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/ov5640.c

index 19e10c59860ba451799e4f7c6c0f0a7400a4dabe..854031f0b64a7390da61b9d3b4e334e0aae42b6a 100644 (file)
@@ -885,7 +885,7 @@ static unsigned long ov5640_calc_sys_clk(struct ov5640_dev *sensor,
                         * We have reached the maximum allowed PLL1 output,
                         * increase sysdiv.
                         */
-                       if (!rate)
+                       if (!_rate)
                                break;
 
                        /*