]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
RDMA/srp: Propagate ib_post_send() failures to the SCSI mid-layer
authorBart Van Assche <bvanassche@acm.org>
Mon, 17 Dec 2018 21:20:36 +0000 (13:20 -0800)
committerDoug Ledford <dledford@redhat.com>
Wed, 19 Dec 2018 20:07:25 +0000 (15:07 -0500)
This patch avoids that the SCSI mid-layer keeps retrying forever if
ib_post_send() fails. This was discovered while testing immediate
data support and passing a too large num_sge value to ib_post_send().

Cc: Sergey Gorenko <sergeygo@mellanox.com>
Cc: Max Gurtovoy <maxg@mellanox.com>
Cc: Laurence Oberman <loberman@redhat.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/ulp/srp/ib_srp.c

index ef8d55dca13643757993370838f9f4e04f05605a..b291278674d8d942b1f396f33d3258787dac7c39 100644 (file)
@@ -2358,6 +2358,7 @@ static int srp_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *scmnd)
 
        if (srp_post_send(ch, iu, len)) {
                shost_printk(KERN_ERR, target->scsi_host, PFX "Send failed\n");
+               scmnd->result = DID_ERROR << 16;
                goto err_unmap;
        }