]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
block: move tag field position in struct request
authorMinwoo Im <minwoo.im.dev@gmail.com>
Sat, 8 Jun 2019 20:15:51 +0000 (05:15 +0900)
committerJens Axboe <axboe@kernel.dk>
Thu, 20 Jun 2019 09:17:05 +0000 (03:17 -0600)
__data_len and __sector are internal fields which should not be accessed
directly in driver-level like the comment above it. But, tag field can
be accessed by driver level directly so that we need to make the comment
right by moving it to some other place.

Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
include/linux/blkdev.h

index 592669bcc5361000a462a487bfc253801388c974..90e6914bea0cfdbc725f7d24b7c4e92f782969bc 100644 (file)
@@ -137,11 +137,11 @@ struct request {
        unsigned int cmd_flags;         /* op and common flags */
        req_flags_t rq_flags;
 
+       int tag;
        int internal_tag;
 
        /* the following two fields are internal, NEVER access directly */
        unsigned int __data_len;        /* total data len */
-       int tag;
        sector_t __sector;              /* sector cursor */
 
        struct bio *bio;