]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/fourcc: Fix undefined left shift in DRM_FORMAT_BIG_ENDIAN macros
authorAdam Jackson <ajax@redhat.com>
Fri, 18 Oct 2019 17:50:41 +0000 (13:50 -0400)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 18 Oct 2019 18:19:24 +0000 (21:19 +0300)
1<<31 is undefined because it's a signed int and C is terrible.

Reviewed-by: Eric Engestrom <eric.engestrom@intel.com>
Signed-off-by: Adam Jackson <ajax@redhat.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191018175041.613780-1-ajax@redhat.com
include/uapi/drm/drm_fourcc.h

index 2376d36ea5733e828b1dd0d4df06079e79cc3941..8caaaf7ff91beb426188d7116979e55615787dd9 100644 (file)
@@ -69,7 +69,7 @@ extern "C" {
 #define fourcc_code(a, b, c, d) ((__u32)(a) | ((__u32)(b) << 8) | \
                                 ((__u32)(c) << 16) | ((__u32)(d) << 24))
 
-#define DRM_FORMAT_BIG_ENDIAN (1<<31) /* format is big endian instead of little endian */
+#define DRM_FORMAT_BIG_ENDIAN (1U<<31) /* format is big endian instead of little endian */
 
 /* Reserve 0 for the invalid format specifier */
 #define DRM_FORMAT_INVALID     0