]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
Bluetooth: btqca: Use correct byte format for opcode of injected command
authorMatthias Kaehlcke <mka@chromium.org>
Mon, 8 Jul 2019 21:57:42 +0000 (14:57 -0700)
committerMarcel Holtmann <marcel@holtmann.org>
Mon, 12 Aug 2019 16:23:50 +0000 (18:23 +0200)
The opcode of the command injected by commit 32646db8cc28 ("Bluetooth:
btqca: inject command complete event during fw download") uses the CPU
byte format, however it should always be little endian. In practice it
shouldn't really matter, since all we need is an opcode != 0, but still
let's do things correctly and keep sparse happy.

Fixes: 32646db8cc28 ("Bluetooth: btqca: inject command complete event during fw download")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/btqca.c

index c59ca5782b637cfe9fe910437bb2034a961d8c86..81a5c45bdcd9440231e80118c110c7c87ff317d6 100644 (file)
@@ -268,7 +268,7 @@ static int qca_inject_cmd_complete_event(struct hci_dev *hdev)
 
        evt = skb_put(skb, sizeof(*evt));
        evt->ncmd = 1;
-       evt->opcode = QCA_HCI_CC_OPCODE;
+       evt->opcode = cpu_to_le16(QCA_HCI_CC_OPCODE);
 
        skb_put_u8(skb, QCA_HCI_CC_SUCCESS);