]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
perf trace: Enclose all events argument lists with ()
authorArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 4 Oct 2019 18:01:30 +0000 (15:01 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 7 Oct 2019 15:22:18 +0000 (12:22 -0300)
So that they look a bit like normal strace-like syscall enter+exit
lines.

They will look even more when we switch from using libtraceevent's
tep_print_event() routine in favour of using all the perf beautifiers
used by the strace-like syscall enter+exit lines.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Luis Cláudio Gonçalves <lclaudio@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-y4fcej6v6u1m644nbxd2r4pg@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-trace.c

index b3fb208cbd30261d7a194c0f13d819b824c2f728..297aeaa9f69d0f636c1c011bca0bba00de2ef3c2 100644 (file)
@@ -2450,7 +2450,7 @@ static int trace__event_handler(struct trace *trace, struct evsel *evsel,
                 */
        }
 
-       fprintf(trace->output, "%s:", evsel->name);
+       fprintf(trace->output, "%s(", evsel->name);
 
        if (perf_evsel__is_bpf_output(evsel)) {
                bpf_output__fprintf(trace, sample);
@@ -2470,7 +2470,7 @@ static int trace__event_handler(struct trace *trace, struct evsel *evsel,
        }
 
 newline:
-       fprintf(trace->output, "\n");
+       fprintf(trace->output, ")\n");
 
        if (callchain_ret > 0)
                trace__fprintf_callchain(trace, sample);