]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
iommu/mediatek: Check for NULL instead of IS_ERR()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 2 Mar 2016 10:10:27 +0000 (13:10 +0300)
committerJoerg Roedel <jroedel@suse.de>
Wed, 2 Mar 2016 14:49:21 +0000 (15:49 +0100)
of_platform_device_create() returns NULL on error, it never returns
error pointers.

Fixes: 0df4fabe208d ('iommu/mediatek: Add mt8173 IOMMU driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/mtk_iommu.c

index 4b9ae64c2fc3be0b88341aba85f0748b9c7e9eff..929a66a81b2b41ea190ad6ae031581b5f3e88dc1 100644 (file)
@@ -627,7 +627,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
                        plarbdev = of_platform_device_create(
                                                larbnode, NULL,
                                                platform_bus_type.dev_root);
-                       if (IS_ERR(plarbdev))
+                       if (!plarbdev)
                                return -EPROBE_DEFER;
                }
                data->smi_imu.larb_imu[i].dev = &plarbdev->dev;
@@ -720,8 +720,8 @@ static int mtk_iommu_init_fn(struct device_node *np)
        struct platform_device *pdev;
 
        pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root);
-       if (IS_ERR(pdev))
-               return PTR_ERR(pdev);
+       if (!pdev)
+               return -ENOMEM;
 
        ret = platform_driver_register(&mtk_iommu_driver);
        if (ret) {