]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
greybus: remove excessive check in gb_connection_hd_cport_quiesce()
authorDenis Efremov <efremov@linux.com>
Wed, 25 Sep 2019 21:36:56 +0000 (00:36 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Oct 2019 13:24:19 +0000 (15:24 +0200)
Function pointer "hd->driver->cport_quiesce" is already checked
at the beginning of gb_connection_hd_cport_quiesce(). Thus, the
second check can be removed.

Signed-off-by: Denis Efremov <efremov@linux.com>
Acked-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20190925213656.8950-1-efremov@linux.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/greybus/connection.c

index fc8f57f97ce62d719515f63f81e4c55f4cbd089a..e3799a53a193066ec87e277ad643e8091e41d26d 100644 (file)
@@ -361,9 +361,6 @@ static int gb_connection_hd_cport_quiesce(struct gb_connection *connection)
        if (connection->mode_switch)
                peer_space += sizeof(struct gb_operation_msg_hdr);
 
-       if (!hd->driver->cport_quiesce)
-               return 0;
-
        ret = hd->driver->cport_quiesce(hd, connection->hd_cport_id,
                                        peer_space,
                                        GB_CONNECTION_CPORT_QUIESCE_TIMEOUT);