]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
DRM: UDL: get rid of useless vblank initialization
authorEugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Fri, 28 Sep 2018 14:41:26 +0000 (17:41 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 23 Oct 2018 13:59:01 +0000 (15:59 +0200)
UDL doesn't support vblank functionality so we don't need to
initialize vblank here (we are able to send page flip
completion events even without vblank initialization)

Moreover current drm_vblank_init call with num_crtcs > 0 causes
sending DRM_EVENT_FLIP_COMPLETE event with zero timestamp every
time. This breaks userspace apps (for example weston) which
relies on timestamp value.

Cc: stable@vger.kernel.org
Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20180928144126.21598-1-Eugeniy.Paltsev@synopsys.com
drivers/gpu/drm/udl/udl_main.c

index f455f095a14685d234569eaed56121d6269393b1..1b014d92855b93991b17911b1fe40e823585dba1 100644 (file)
@@ -350,15 +350,10 @@ int udl_driver_load(struct drm_device *dev, unsigned long flags)
        if (ret)
                goto err;
 
-       ret = drm_vblank_init(dev, 1);
-       if (ret)
-               goto err_fb;
-
        drm_kms_helper_poll_init(dev);
 
        return 0;
-err_fb:
-       udl_fbdev_cleanup(dev);
+
 err:
        if (udl->urbs.count)
                udl_free_urb_list(dev);